Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken stream when authentication failed #260

Merged
merged 6 commits into from
Jul 19, 2022
Merged

fix: broken stream when authentication failed #260

merged 6 commits into from
Jul 19, 2022

Conversation

RolandMa1986
Copy link
Contributor

PR Type

Bug Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

The handler's signature has been changed. I'm not sure whether it's acceptable. Please let me known it there's a better solution.

@RolandMa1986
fix: broken http stream when authentication failed
29abd79 
Signed-off-by: Roland Ma <rolandma@outlook.com>
@RolandMa1986
remove unchanged
c067dcb 
Signed-off-by: Roland Ma <rolandma@outlook.com>
@robjtede robjtede added A-httpauth Project: actix-web-httpauth B-semver-major breaking change requiring a major version bump labels Jul 15, 2022
@robjtede robjtede requested a review from a team July 15, 2022 13:41
JohnTitor
JohnTitor approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, +1

@RolandMa1986
Copy link
Contributor Author

I don't see any relations between the commit and the failing doc tests. How do i to fix it?

@JohnTitor
Copy link
Member

Due to rust-lang/rust#99261, let's ignore it for now.

robjtede
robjtede approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change seems fine, no better way to do it with the current middleware system so worth providing a solution instead of none

@robjtede robjtede merged commit 417c06b into actix:master Jul 19, 2022
@robjtede robjtede mentioned this pull request Jul 19, 2022
Closed
4 tasks
@jacob-pro
Copy link

this is a neat way of solving the bug within the current constraints - thank you @RolandMa1986

@robjtede robjtede linked an issue Jul 19, 2022 that may be closed by this pull request
Conflict between HttpAuthentication::bearer and actix-cors #127
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
A-httpauth Project: actix-web-httpauth B-semver-major breaking change requiring a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict between HttpAuthentication::bearer and actix-cors
4 participants
@RolandMa1986 @JohnTitor @jacob-pro @robjtede